Feature/user data pagination#891
Conversation
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
…anVeer/website-dashboard into feature/user-data-pagination
|
vinit717
left a comment
vinit717
left a comment
There was a problem hiding this comment.
Please put your feature behind feature flag also remove the mock data and comments
and what about the paginate API?
We had this conversation previously: |
|
Hey who is working on backend for this? |
…ashboard into feature/user-data-pagination
|
AnujChhikara
left a comment
AnujChhikara
left a comment
There was a problem hiding this comment.
- can you please attach test coverage of the App.test.js
- also please attach a video of changes working with dev flag
Screen.Recording.2024-11-11.at.10.54.26.AM.mov |
…ashboard into feature/user-data-pagination
MehulKChaudhari
left a comment
MehulKChaudhari
left a comment
There was a problem hiding this comment.
Just one minor addition, I believe rest of the things are good to go.
vinit717
left a comment
vinit717
left a comment
There was a problem hiding this comment.
How you will test your feature on staging and prod?
| // add feature flag(feature should be only visible when query params dev=true) | ||
|
|
||
| export const paginateFetchedUsers = async (tabId, page = 1) => { | ||
| if (isLoading) { |
There was a problem hiding this comment.
How you are checking this condition?
There was a problem hiding this comment.
checked it with mock data, so when data is not being loaded the loading spinner is rendered.
There was a problem hiding this comment.
how did you determine isLoading and where are you getting this from ?
Will take up task to work on backend and then merge both the tasks. |
So start working on the backend first |
7 participants
Date: 15/10/2024
Developer Name: Ishan Veer
Issue Ticket Number
Description
Previously all the data was being fetched at once which can cause performance issues. So things I worked on:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Currently testing it with mock data because API is still not paginated.